-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add DuckDB EmbeddingStore implementation (#2183) #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fb64 Thank you! Could you please check tests? Looks like it passed in my local env but failed in Github Actions.
...munity-duckdb/src/main/java/dev/langchain4j/store/embedding/duckdb/DuckDBEmbeddingStore.java
Outdated
Show resolved
Hide resolved
...munity-duckdb/src/main/java/dev/langchain4j/store/embedding/duckdb/DuckDBEmbeddingStore.java
Outdated
Show resolved
Hide resolved
...nity-duckdb/src/main/java/dev/langchain4j/store/embedding/duckdb/DuckDBJsonFilterMapper.java
Outdated
Show resolved
Hide resolved
...munity-duckdb/src/main/java/dev/langchain4j/store/embedding/duckdb/DuckDBEmbeddingStore.java
Outdated
Show resolved
Hide resolved
...munity-duckdb/src/main/java/dev/langchain4j/store/embedding/duckdb/DuckDBEmbeddingStore.java
Outdated
Show resolved
Hide resolved
...munity-duckdb/src/main/java/dev/langchain4j/store/embedding/duckdb/DuckDBEmbeddingStore.java
Outdated
Show resolved
Hide resolved
...munity-duckdb/src/main/java/dev/langchain4j/store/embedding/duckdb/DuckDBEmbeddingStore.java
Outdated
Show resolved
Hide resolved
bf64ccd
to
18a035b
Compare
I'll check, but actually everything passed on my local env too 🤔 |
I think I fixed the issue, by casting the sql string into float[]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fb64 Thank you! Could you please add docs in langchain4j main repo?
Issue
Closes langchain4j#2183
Change
Add implementation of EmbeddingStore with DuckDB that supports metadata.
Replace langchain4j/langchain4j#2184
General checklist
Checklist for adding new maven module
pom.xml
andlangchain4j-bom/pom.xml
Checklist for adding new embedding store integration
{NameOfIntegration}EmbeddingStoreIT
that extends from eitherEmbeddingStoreIT
orEmbeddingStoreWithFilteringIT
{NameOfIntegration}EmbeddingStoreRemovalIT
that extends fromEmbeddingStoreWithRemovalIT